Added DigraphMinimumCutSet
#879
Conversation
…ough all triples of vertices, and instead checks center vertices of 2-edges
…2EdgeTransitive has multiple edges to doc
reiniscirpons
left a comment
reiniscirpons
left a comment
There was a problem hiding this comment.
Thanks for the contribution, looks solid, some suggestions for docs and performance above, mostly minor.
In addition to the comments above, it looks like doc for the function is not linked in the manual, you should add
<#Include Label="DigraphMinimumCut">to z-chap5.xml in the appropriate location to get your documentation to show up in the manual (you can test this by seeing if ?DigraphMinimumCut finds the doc inside of gap).
I would also suggest changing the name of the function to DigraphMinimumCut since what its computing is the cut not the cut-set (see the definitions in https://en.wikipedia.org/wiki/Max-flow_min-cut_theorem#Cuts). It might also be good to implement a separate DigraphMinimumCutSet which wraps your current function and computes the edges.
|
Looks good to me, thanks again for the contribution @frankiegillis ! I made a minor correction to the docs just now: minimal and minimum mean slightly different things. So minimal is more akin of a local minimum, i.e. there is no way to make it smaller by swapping a single point between the partitions in this context). Ill way for the CI to pass and then its good to merge! |
reiniscirpons
added
merge-in-to-master
3 participants
This adds the function
DigraphMinimumCutSetusing theDigraphMaximumFlowmethod and the max-flow min-cut theorem. See issue #867.